-
Notifications
You must be signed in to change notification settings - Fork 161
Refactored out the policy files and their usages #25646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Atwijukire Ariho Seth <[email protected]>
Signed-off-by: Atwijukire Ariho Seth <[email protected]>
Signed-off-by: Atwijukire Ariho Seth <[email protected]>
|
@dmatej do we want to remove the security manager also in 7.1? Is it needed to run on Java 24 and 25? Edit: I checked and apps still run on Java 24 and 25 even if they use Security Manager API. It just cannot be enabled. So it’s better to target this PR for 8.0 branch, where we plan to remove Security Manager support completely @Ariho-Seth , can you rebase on branch 8.0 or cherry pick your commits to it? |
|
Ohhh yeah, I hadn't realised the milestone tag on the issue, I've seen that too, let me rebase it on the 8.0 branch |
|
Hello @OndroMih, I tried rebasing it onto the Any help? I tried uncommenting the commands in the |
Read readme: Line 53 in df02570
|
Sure, thanks, though still some dependencies are not being resolved even after running using the profile |
Hmmm, that would mean the published SNAPSHOT dependency on the Jakarta Data / NoSQL work resolves to an older version. @OndroMih can you take a look? |
|
Yes, currently it's not possible to build 8.0 version until #25645 is merged, sorry. |
|
@Ariho-Seth , meanwhile, you can merge my branch https://github.com/OndroMih/glassfish/tree/ondromih-jakarta-data-persistence-wip-glassfish into 8.0 locally and then you should be able to build. |
|
#25645 is merged, so the build of the 8.0 branch should work now. |
|
Don't do this yet, or we get into conflict with huge #25640 - it removed several files already, redundant even for GF7, and changed some things around. I am working on the PR, in few days/weeks it should be done as I need to pass the TCK too with it. |
Hello @OndroMih, I updated my local branch too, though this time round the build is failing due to a test in |
And this looks to be the same with the |
|
Moving this to draft. @Ariho-Seth , please postpone work on this until we're finished with merging this PR: #25640 as @dmatej wrote. |
D'accord, yeah, I will be working on other issues then until we are ready. |
|
Hi, @Ariho-Seth, I moved your question about the failing test into a separate dicussion: #25657 |
This PR ;
Removes policy files, ie,
client.policy,security.policyRemoves all imports for
java.security.Policy, for examplePolicy.getPolicy(),Policy.setPolicy(),Policy.refresh()Removes all the code that instantiates
java.lang.SecurityManager, for example,new SecurityManager(),System.getSecurityManager(), andSystem.setSecurityManager()Removes all related JVM options:
java.security.policy.Removes all methods like
refreshPolicy()&removePolicy()Fixes #25519